Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES|QL: fix lookup-join csv tests with nondeterministic order #118008

Merged
merged 2 commits into from
Dec 4, 2024
Merged

ES|QL: fix lookup-join csv tests with nondeterministic order #118008

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18d635c
ES|QL: fix lookup-join csv tests with nondeterministic order
luigidellaquila Dec 4, 2024
81850d2
Merge branch 'main' into esql/fix_lookup_join_tests_order
craigtaverner Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,20 +239,6 @@ tests:
- class: org.elasticsearch.xpack.ml.integration.RegressionIT
method: testTwoJobsWithSameRandomizeSeedUseSameTrainingSet
issue: https://github.com/elastic/elasticsearch/issues/117805
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {lookup-join.LookupIPFromIndexKeep ASYNC}
issue: https://github.com/elastic/elasticsearch/issues/117974
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {lookup-join.LookupMessageFromIndex ASYNC}
issue: https://github.com/elastic/elasticsearch/issues/117975
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {lookup-join.LookupMessageFromIndexKeep ASYNC}
issue: https://github.com/elastic/elasticsearch/issues/117976
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {lookup-join.LookupMessageFromIndex SYNC}
issue: https://github.com/elastic/elasticsearch/issues/117980
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
issue: https://github.com/elastic/elasticsearch/issues/117981
Comment on lines -242 to -255
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that this PR fixes all of these CI failures, not just #117981 .

- class: org.elasticsearch.packaging.test.ArchiveGenerateInitialCredentialsTests
method: test30NoAutogenerationWhenDaemonized
issue: https://github.com/elastic/elasticsearch/issues/117956
Expand Down
4 changes: 4 additions & 0 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/lookup-join.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ FROM sample_data
| EVAL client_ip = client_ip::keyword
| LOOKUP JOIN clientips_lookup ON client_ip
;
ignoreOrder:true;

@timestamp:date | event_duration:long | message:keyword | client_ip:keyword | env:keyword
2023-10-23T13:55:01.543Z | 1756467 | Connected to 10.1.0.1 | 172.21.3.15 | Production
Expand All @@ -146,6 +147,7 @@ FROM sample_data
| LOOKUP JOIN clientips_lookup ON client_ip
| KEEP @timestamp, client_ip, event_duration, message, env
;
ignoreOrder:true;

@timestamp:date | client_ip:keyword | event_duration:long | message:keyword | env:keyword
2023-10-23T13:55:01.543Z | 172.21.3.15 | 1756467 | Connected to 10.1.0.1 | Production
Expand Down Expand Up @@ -230,6 +232,7 @@ required_capability: join_lookup_v4
FROM sample_data
| LOOKUP JOIN message_types_lookup ON message
;
ignoreOrder:true;

@timestamp:date | client_ip:ip | event_duration:long | message:keyword | type:keyword
2023-10-23T13:55:01.543Z | 172.21.3.15 | 1756467 | Connected to 10.1.0.1 | Success
Expand All @@ -248,6 +251,7 @@ FROM sample_data
| LOOKUP JOIN message_types_lookup ON message
| KEEP @timestamp, client_ip, event_duration, message, type
;
ignoreOrder:true;

@timestamp:date | client_ip:ip | event_duration:long | message:keyword | type:keyword
2023-10-23T13:55:01.543Z | 172.21.3.15 | 1756467 | Connected to 10.1.0.1 | Success
Expand Down