Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull AWS SDK versions to top level #118247

Merged

Conversation

DaveCTurner
Copy link
Contributor

Today each relevant module defines the version of the AWS SDK that it
uses, which means there's a risk that we use different versions in
different modules. This commit pulls the version declarations to the top
level to make sure we keep everything in sync.

Today each relevant module defines the version of the AWS SDK that it
uses, which means there's a risk that we use different versions in
different modules. This commit pulls the version declarations to the top
level to make sure we keep everything in sync.
@DaveCTurner DaveCTurner added >non-issue :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :SearchOrg/Inference Label for the Search Inference team v9.0.0 v8.18.0 labels Dec 9, 2024
@DaveCTurner DaveCTurner requested a review from pxsalehi December 9, 2024 10:34
@DaveCTurner DaveCTurner requested a review from a team as a code owner December 9, 2024 10:34
@elasticsearchmachine elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) Team:Search - Inference Team:Distributed Coordination Meta label for Distributed Coordination team labels Dec 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-inference-team (Team:Search - Inference)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels Dec 9, 2024
@elasticsearchmachine elasticsearchmachine merged commit 64e0902 into elastic:main Dec 9, 2024
16 checks passed
@DaveCTurner DaveCTurner deleted the 2024/12/09/aws-sdk-versions branch December 9, 2024 12:12
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 9, 2024
Today each relevant module defines the version of the AWS SDK that it
uses, which means there's a risk that we use different versions in
different modules. This commit pulls the version declarations to the top
level to make sure we keep everything in sync.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

elasticsearchmachine pushed a commit that referenced this pull request Dec 9, 2024
Today each relevant module defines the version of the AWS SDK that it
uses, which means there's a risk that we use different versions in
different modules. This commit pulls the version declarations to the top
level to make sure we keep everything in sync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue :SearchOrg/Inference Label for the Search Inference team Team:Distributed Coordination Meta label for Distributed Coordination team Team:Search - Inference Team:SearchOrg Meta label for the Search Org (Enterprise Search) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants