-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull AWS SDK versions to top level #118247
Merged
elasticsearchmachine
merged 1 commit into
elastic:main
from
DaveCTurner:2024/12/09/aws-sdk-versions
Dec 9, 2024
Merged
Pull AWS SDK versions to top level #118247
elasticsearchmachine
merged 1 commit into
elastic:main
from
DaveCTurner:2024/12/09/aws-sdk-versions
Dec 9, 2024
+33
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today each relevant module defines the version of the AWS SDK that it uses, which means there's a risk that we use different versions in different modules. This commit pulls the version declarations to the top level to make sure we keep everything in sync.
DaveCTurner
added
>non-issue
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
:Distributed Coordination/Discovery-Plugins
Anything related to our integration plugins with EC2, GCP and Azure
:SearchOrg/Inference
Label for the Search Inference team
v9.0.0
v8.18.0
labels
Dec 9, 2024
elasticsearchmachine
added
Team:SearchOrg
Meta label for the Search Org (Enterprise Search)
Team:Search - Inference
Team:Distributed Coordination
Meta label for Distributed Coordination team
labels
Dec 9, 2024
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Pinging @elastic/search-eng (Team:SearchOrg) |
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
pxsalehi
approved these changes
Dec 9, 2024
DaveCTurner
added
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
auto-backport
Automatically create backport pull requests when merged
labels
Dec 9, 2024
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 9, 2024
Today each relevant module defines the version of the AWS SDK that it uses, which means there's a risk that we use different versions in different modules. This commit pulls the version declarations to the top level to make sure we keep everything in sync.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 9, 2024
Today each relevant module defines the version of the AWS SDK that it uses, which means there's a risk that we use different versions in different modules. This commit pulls the version declarations to the top level to make sure we keep everything in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Distributed Coordination/Discovery-Plugins
Anything related to our integration plugins with EC2, GCP and Azure
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>non-issue
:SearchOrg/Inference
Label for the Search Inference team
Team:Distributed Coordination
Meta label for Distributed Coordination team
Team:Search - Inference
Team:SearchOrg
Meta label for the Search Org (Enterprise Search)
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today each relevant module defines the version of the AWS SDK that it
uses, which means there's a risk that we use different versions in
different modules. This commit pulls the version declarations to the top
level to make sure we keep everything in sync.