Replacing sigar #11995
Closed
Replacing sigar #11995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
v2.0.0-beta1
review
:Data Management/Stats
|
For the record, here are some data collected by the Empty values means "not supported". Linux - Oracle Corporation Java HotSpot(TM) 64-Bit Server VM (1.8.0_20)
Linux - Oracle Corporation OpenJDK 64-Bit Server VM (1.7.0_79)
Windows 8.1 - Oracle Corporation Java HotSpot(TM) 64-Bit Server VM (1.8.0_25)
|
| public Long processSystemTime() { | ||
| if (!threadMxBean.isThreadCpuTimeSupported()) { | ||
| throw new UnsupportedOperationException("JmxProcessProbe does not support process user time"); | ||
| } |
There was a problem hiding this comment.
Do you happen to know if any platforms where this returns false?
There was a problem hiding this comment.
No. This method is documented as the flag to indicate if CPU time is supported, I think it makes sense to use it here before requesting value
|
Closed in favor of #12010 , I keep the code here for the record. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step in order to remove sigar (see #11034)
This pull request removes all Sigar stuff and adds the ability to query multiple probes at once. It focused on
Processstats/info for now and serves as an example for the other stats we have (Os, Fs, Network).