Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thirdPartyAudit task when running on Java 24 #121712

Merged

Conversation

mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented Feb 4, 2025

We need to explicitly add the incubating vector API module to the third party audit task on Java 24.

@mark-vieira mark-vieira added >non-issue :Delivery/Build Build or test infrastructure auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged v9.0.0 v8.17.2 v8.16.4 v8.18.1 v8.19.0 labels Feb 4, 2025
@mark-vieira mark-vieira requested a review from a team as a code owner February 4, 2025 21:30
@elasticsearchmachine elasticsearchmachine added Team:Delivery Meta label for Delivery team v9.1.0 labels Feb 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine merged commit 0c667ec into elastic:main Feb 4, 2025
18 checks passed
@mark-vieira mark-vieira deleted the java-24-third-party-audit-fix branch February 4, 2025 23:30
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0
8.17 Commit could not be cherrypicked due to conflicts
8.16 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 121712

mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 4, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 5, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.

(cherry picked from commit 0c667ec)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 5, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.

(cherry picked from commit 0c667ec)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 5, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.

(cherry picked from commit 0c667ec)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
@mark-vieira
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x
8.18
8.17
8.16

Questions ?

Please refer to the Backport tool documentation

mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 5, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.

(cherry picked from commit 0c667ec)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
elasticsearchmachine pushed a commit that referenced this pull request Feb 5, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.
mark-vieira added a commit that referenced this pull request Feb 6, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.

(cherry picked from commit 0c667ec)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
mark-vieira added a commit that referenced this pull request Feb 6, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.

(cherry picked from commit 0c667ec)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
mark-vieira added a commit that referenced this pull request Feb 6, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.

(cherry picked from commit 0c667ec)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
mark-vieira added a commit that referenced this pull request Feb 6, 2025
We need to explicitly add the incubating vector API module to the third
party audit task on Java 24.

(cherry picked from commit 0c667ec)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/precommit/ThirdPartyAuditTask.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.16.4 v8.17.2 v8.18.1 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants