Upgrade to Lucene 10.2.1 #127343
Open
Upgrade to Lucene 10.2.1 #127343
+96
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
ChrisHegarty
added
test-full-bwc
|
Hi @ChrisHegarty, I've created a changelog YAML for you. |
ChrisHegarty
commented
Apr 28, 2025
| TotalHits totalHits = context.queryResult().topDocs().topDocs.totalHits; | ||
| assertThat(totalHits.value(), greaterThanOrEqualTo(5L)); | ||
| var expectedRelation = totalHits.value() == 10 ? Relation.EQUAL_TO : Relation.GREATER_THAN_OR_EQUAL_TO; | ||
| assertThat(totalHits.relation(), is(expectedRelation)); |
There was a problem hiding this comment.
Test updated as per apache/lucene#14561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades to Lucene 10.2.1.
Given that we're on a snapshot, there are a few things to note:
No index version update is necessary, we already have
IndexVersions.UPGRADE_TO_LUCENE_10_2_1, and there are no format changes in the final non-snapshot release.The RC repo will be remove before this PR is merged.
relates: #127125