Move ES|QL sample command from snapshot to tech preview #129540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.1.0
needs:triage
There was a problem hiding this comment.
Pull Request Overview
This PR moves the ES|QL SAMPLE command and its related parameter support from being enabled only on snapshot builds to always enabled as part of tech preview.
- Removes conditional enabling based on Build.current().isSnapshot() for SAMPLE_V3
- Removes conditional enabling based on Build.current().isSnapshot() for PARAMETER_FOR_SAMPLE
Comments suppressed due to low confidence (2)
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java:1085
- Since the conditional flag has been removed for SAMPLE_V3, please update the Javadoc to reflect that it is now part of the tech preview rather than available only on snapshot builds.
SAMPLE_V3,
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java:1210
- Since the conditional flag has been removed for PARAMETER_FOR_SAMPLE, please update its associated documentation to indicate that this capability is now available in tech preview.
PARAMETER_FOR_SAMPLE;
jan-elastic
added
:ml
|
Pinging @elastic/ml-core (Team:ML) |
alex-spies
reviewed
Jun 17, 2025
There was a problem hiding this comment.
Documentation already updated in #129350.
@jan-elastic, this change only enables the SAMPLE tests in non-SNAPSHOT builds - to actually enable it, you'll need to update the grammar and move SAMPLE out of the dev commands/stop guarding it behind this.isDevVersion().
alex-spies
approved these changes
Jun 17, 2025
|
Should this be backported to 8.19, too? |
jan-elastic
force-pushed
the
esql-command-tech-preview
branch
from
d5d0631 to
2d383cc
Compare
All of SAMPLE still needs to be backported; that's on my todo list for this week |
jan-elastic
force-pushed
the
esql-command-tech-preview
branch
from
2d383cc to
567b937
Compare
jan-elastic
force-pushed
the
esql-command-tech-preview
branch
from
567b937 to
479a84a
Compare
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jun 18, 2025
* Move ES|QL sample command from snapshot to tech preview * dev_sample -> sample * fix test * fix grammar
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jun 19, 2025
* Move ES|QL sample command from snapshot to tech preview * dev_sample -> sample * fix test * fix grammar
jan-elastic
added a commit
that referenced
this pull request
Jun 19, 2025
* ES|QL random sampling (#125570) * test: check ES|QL SAMPLE capability before running analyzer/parser tests (#127382) This commit resolves release test failures by checking the ES|QL SAMPLE capability before running the tests. * Fix ES|QL sample csv tests (#127838) * Remove optional seed from ES|QL SAMPLE (#128887) * Remove optional seed from ES|QL SAMPLE * make it clear that seed is for testing * rename ES|QL sample capability (#129193) * remove stats correction from ES|QL sample (#129319) * remove stats correction from ES|QL sample * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> * Allow parameter for ES|QL SAMPLE (#129392) * Allow parameter for ES|QL SAMPLE * fix test to work around issue #120272 * remove unused postAnalysisVerification * docs * [CI] Auto commit changes from spotless * fix usage * Move ES|QL sample command from snapshot to tech preview (#129540) * Move ES|QL sample command from snapshot to tech preview * dev_sample -> sample * fix test * fix grammar --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.