Skip to content

Fix typo in feature flag #134971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2025
Merged

Fix typo in feature flag #134971

merged 4 commits into from
Sep 18, 2025

Conversation

parkertimmins
Copy link
Contributor

@parkertimmins parkertimmins commented Sep 18, 2025 •
edited by martijnvg
Loading

Closes #134969

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.2.0 labels Sep 18, 2025
@parkertimmins parkertimmins added >non-issue :StorageEngine/Mapping The storage related side of mappings labels Sep 18, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Sep 18, 2025
@parkertimmins
Copy link
Contributor Author

This is meant as a fix for #134969 ... but to be honest I'm not confident that this is the correct way to handle this issue. It's also possible that I messed something up during the rename.

@parkertimmins parkertimmins added the test-release Trigger CI checks against release build label Sep 18, 2025
@dnhatn
Copy link
Member

dnhatn commented Sep 18, 2025

I think we will also need to guard the YAML test.


REPRODUCE WITH: ./gradlew ":x-pack:plugin:logsdb:yamlRestTest" --tests "org.elasticsearch.xpack.logsdb.LogsdbTestSuiteIT.test {yaml=patterntext/30_template_id/Sort by template_id ascending from request}" -Dtests.seed=4861448B902F5F9A -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dlicense.key=x-pack/license-tools/src/test/resources/public.key -Dtests.locale=lu-Latn-CD -Dtests.timezone=Asia/Omsk -Druntime.java=24

@jordan-powers
Copy link
Contributor

Last time I had yaml tests that depended on a snapshot-only feature flag, the delivery team advised I do something like: df518aa. We'll probably need to do something similar here.

@martijnvg
Copy link
Member

I see that LogsdbTestSuiteIT already sets up the test cluster with pattern text feature flag. This should be sufficient to avoid these test failures.

@martijnvg
Copy link
Member

As part of the the rename from patterned_text to pattern_text, the FeatureFlag.PATTERN_TEXT name wasn't updated. Pushed a fix for this.

@martijnvg martijnvg enabled auto-merge (squash) September 18, 2025 04:58
@martijnvg martijnvg disabled auto-merge September 18, 2025 05:00
@martijnvg martijnvg changed the title Only run PatternTextBasicRestIT on snapshot builds Fix typo in feature flag Sep 18, 2025
@martijnvg martijnvg enabled auto-merge (squash) September 18, 2025 05:10
@martijnvg martijnvg merged commit d37c0e5 into elastic:main Sep 18, 2025
35 checks passed
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Sep 18, 2025
@martijnvg
Unmute pattern text tests.
6c72766 
Is fixed via elastic#134971, but these tests were auto-muted just around the time the fix was merged.

Closes elastic#134976
Closes elastic#134975
@martijnvg martijnvg mentioned this pull request Sep 18, 2025
Merged
martijnvg added a commit that referenced this pull request Sep 18, 2025
@martijnvg
Unmute pattern text tests. (#134981)
eb3bc2f 
Is fixed via #134971, but these tests were auto-muted just around the time the fix was merged.

Closes #134976
Closes #134975
gmjehovich pushed a commit to gmjehovich/elasticsearch that referenced this pull request Sep 18, 2025
@parkertimmins @martijnvg @gmjehovich
Fix typo in feature flag (elastic#134971)
2b67f15 
Closes elastic#134969

Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com>
gmjehovich pushed a commit to gmjehovich/elasticsearch that referenced this pull request Sep 18, 2025
@martijnvg @gmjehovich
Unmute pattern text tests. (elastic#134981)
50b424c 
Is fixed via elastic#134971, but these tests were auto-muted just around the time the fix was merged.

Closes elastic#134976
Closes elastic#134975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees

No one assigned

Labels

>non-issue :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine test-release Trigger CI checks against release build v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PatternTextBasicRestIT fails

5 participants

@parkertimmins @elasticsearchmachine @dnhatn @jordan-powers @martijnvg