Skip to content

Conversation

@Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Oct 2, 2025

Defer failures on semantic_text fields created in pre-8.11 indices to when the first document is ingested. This is accomplished by reverting #133080 and moving the index version check to when the document is parsed.

@Mikep86 Mikep86 requested a review from kderusso October 2, 2025 13:17
@Mikep86 Mikep86 added >bug auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.2.0 v8.19.5 v9.1.5 v8.18.8 v9.0.8 labels Oct 2, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search - Relevance The Search organization Search Relevance team v9.3.0 labels Oct 2, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@elasticsearchmachine
Copy link
Collaborator

Hi @Mikep86, I've created a changelog YAML for you.

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks for fixing

@Mikep86 Mikep86 merged commit 66d9241 into elastic:main Oct 2, 2025
34 checks passed
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.2
8.19 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 135845

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
@Mikep86
Copy link
Contributor Author

Mikep86 commented Oct 2, 2025

💔 Some backports could not be created

Status Branch Result
9.1
9.0 Conflict resolution was aborted by the user
8.19
8.18

Manual backport

To create the backport manually run:

backport --pr 135845

Questions ?

Please refer to the Backport tool documentation

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
@Mikep86
Copy link
Contributor Author

Mikep86 commented Oct 2, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 2, 2025
(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
…5869)

* Defer Semantic Text Failures on Pre-8.11 Indices (#135845)

(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

* [CI] Auto commit changes from spotless

* Update comment

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
…35871)

* Defer Semantic Text Failures on Pre-8.11 Indices (#135845)

(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

* [CI] Auto commit changes from spotless

* Update comment

* Fix compile errors

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
…5872)

* Defer Semantic Text Failures on Pre-8.11 Indices (#135845)

(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

* Update comment

* [CI] Auto commit changes from spotless

* Fix compile errors

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
…35870)

* Defer Semantic Text Failures on Pre-8.11 Indices (#135845)

(cherry picked from commit 66d9241)

# Conflicts:
#	server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/mapper/SemanticTextFieldMapper.java

* [CI] Auto commit changes from spotless

* Update comment

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
sorenlouv added a commit to elastic/kibana that referenced this pull request Oct 9, 2025
…rom 8.10 to 8.18" (#238117)

Closes #233043
This test broke due to an Elasticsearch change:
elastic/elasticsearch#135845

Related:

- #233242
- #233043
-
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2025
…rom 8.10 to 8.18" (elastic#238117)

Closes elastic#233043
This test broke due to an Elasticsearch change:
elastic/elasticsearch#135845

Related:

- elastic#233242
- elastic#233043
-

(cherry picked from commit 7fc4c39)
kibanamachine added a commit to elastic/kibana that referenced this pull request Oct 9, 2025
…ding from 8.10 to 8.18" (#238117) (#238172)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Obs AI Assistant] Unskip API test: “Knowledge base: when upgrading
from 8.10 to 8.18"
(#238117)](#238117)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-10-09T07:38:08Z","message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.3.0"],"title":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to
8.18\"","number":238117,"url":"https://github.com/elastic/kibana/pull/238117","mergeCommit":{"message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238117","number":238117,"mergeCommit":{"message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551"}}]}]
BACKPORT-->

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Oct 10, 2025
…rom 8.10 to 8.18" (elastic#238117)

Closes elastic#233043
This test broke due to an Elasticsearch change:
elastic/elasticsearch#135845

Related:

- elastic#233242
- elastic#233043
-

(cherry picked from commit 7fc4c39)
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Oct 10, 2025
…rom 8.10 to 8.18" (elastic#238117)

Closes elastic#233043
This test broke due to an Elasticsearch change:
elastic/elasticsearch#135845

Related:

- elastic#233242
- elastic#233043
-

(cherry picked from commit 7fc4c39)

# Conflicts:
#	x-pack/platform/plugins/shared/observability_ai_assistant/server/service/startup_migrations/run_startup_migrations.ts
#	x-pack/solutions/observability/test/api_integration_deployment_agnostic/apis/ai_assistant/knowledge_base/knowledge_base_8.10_upgrade_test.spec.ts
sorenlouv added a commit to elastic/kibana that referenced this pull request Oct 10, 2025
…ading from 8.10 to 8.18" (#238117) (#238375)

Closes #233243

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Obs AI Assistant] Unskip API test: “Knowledge base: when upgrading
from 8.10 to 8.18"
(#238117)](#238117)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-10-09T07:38:08Z","message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.3.0","v9.1.6"],"title":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to
8.18\"","number":238117,"url":"https://github.com/elastic/kibana/pull/238117","mergeCommit":{"message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238172","number":238172,"state":"MERGED","mergeCommit":{"sha":"2bd22d437fda2194120f449a47add20ad4ec1300","message":"[9.1]
[Obs AI Assistant] Unskip API test: “Knowledge base: when upgrading from
8.10 to 8.18\" (#238117) (#238172)\n\n# Backport\n\nThis will backport
the following commits from `main` to `9.1`:\n- [[Obs AI Assistant]
Unskip API test: “Knowledge base: when upgrading\nfrom 8.10 to
8.18\"\n(#238117)](https://github.com/elastic/kibana/pull/238117)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Søren Louv-Jansen
<soren.louv@elastic.co>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238117","number":238117,"mergeCommit":{"message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551"}}]}]
BACKPORT-->
sorenlouv added a commit to elastic/kibana that referenced this pull request Oct 10, 2025
…ading from 8.10 to 8.18" (#238117) (#238377)

Closes: #233242

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Obs AI Assistant] Unskip API test: “Knowledge base: when upgrading
from 8.10 to 8.18"
(#238117)](#238117)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-10-09T07:38:08Z","message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:version","v8.18.0","v9.1.0","v8.19.0","v9.3.0","v9.1.6"],"title":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to
8.18\"","number":238117,"url":"https://github.com/elastic/kibana/pull/238117","mergeCommit":{"message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/238172","number":238172,"state":"MERGED","mergeCommit":{"sha":"2bd22d437fda2194120f449a47add20ad4ec1300","message":"[9.1]
[Obs AI Assistant] Unskip API test: “Knowledge base: when upgrading from
8.10 to 8.18\" (#238117) (#238172)\n\n# Backport\n\nThis will backport
the following commits from `main` to `9.1`:\n- [[Obs AI Assistant]
Unskip API test: “Knowledge base: when upgrading\nfrom 8.10 to
8.18\"\n(#238117)](https://github.com/elastic/kibana/pull/238117)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Søren Louv-Jansen
<soren.louv@elastic.co>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238117","number":238117,"mergeCommit":{"message":"[Obs
AI Assistant] Unskip API test: “Knowledge base: when upgrading from 8.10
to 8.18\" (#238117)\n\nCloses
https://github.com/elastic/kibana/issues/233043\nThis test broke due to
an Elasticsearch
change:\nhttps://github.com/elastic/elasticsearch/pull/135845\n\nRelated:\n\n-
https://github.com/elastic/kibana/issues/233242\n-
https://github.com/elastic/kibana/issues/233043\n-","sha":"7fc4c393f189a4c9a17d142a7c89a49474b6e551"}}]}]
BACKPORT-->
rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team v8.18.8 v8.19.5 v9.0.8 v9.1.5 v9.2.0 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants