Skip to content

Remove duplicate path.repo setting in AbstractIndexCompatibilityTestCase #138264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove duplicate path.repo setting in AbstractIndexCompatibilityTestCase #138264

wants to merge 1 commit into from
+0 −1

Conversation

@JeremyDahlgren
Copy link
Contributor

@JeremyDahlgren JeremyDahlgren commented Nov 18, 2025

The static ElasticsearchCluster cluster initialization method chain had a duplicate line:
.setting("path.repo", () -> REPOSITORY_PATH.getRoot().getPath()).

Saw this while looking into a RollingUpgradeDeprecatedSettingsIT failure.

@JeremyDahlgren JeremyDahlgren added >test Issues or PRs that are addressing/adding tests Team:Distributed Coordination Meta label for Distributed Coordination team :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. v9.3.0 labels Nov 18, 2025
@JeremyDahlgren JeremyDahlgren requested a review from tlrx November 18, 2025 23:46
@JeremyDahlgren JeremyDahlgren marked this pull request as ready for review November 18, 2025 23:46
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 18, 2025

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

tlrx
tlrx approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jeremy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrx tlrx tlrx approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeremyDahlgren @elasticsearchmachine @tlrx