Skip to content

Minor cleanups for MMR Diversify Retriever #138910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markjhoy merged 7 commits into from
Dec 2, 2025
Merged

Minor cleanups for MMR Diversify Retriever #138910

markjhoy merged 7 commits into from
Dec 2, 2025
+94 −16

Conversation

@markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Dec 2, 2025

Some cleanups as a follow on to: #135880

  • Ensure size field is not negative, and add YAML tests
  • At the start of the MMR algorithm, If a query_vector is provided, for each row, compute the similarity between field and query_vector. Choose highest query_vector similarity doc, or, highest scoring doc if none.

@markjhoy markjhoy requested a review from a team December 2, 2025 15:41
@markjhoy markjhoy added :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team v9.3.0 labels Dec 2, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Dec 2, 2025

Pinging @elastic/search-relevance (Team:Search - Relevance)

@markjhoy markjhoy requested review from a team and ioanatia December 2, 2025 16:18
@markjhoy markjhoy requested review from a team and mromaios December 2, 2025 16:41
@markjhoy markjhoy enabled auto-merge (squash) December 2, 2025 21:08
mromaios
mromaios approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@mromaios mromaios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@markjhoy markjhoy merged commit c5d5d55 into elastic:main Dec 2, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mromaios mromaios mromaios approved these changes

@ioanatia ioanatia Awaiting requested review from ioanatia

Assignees

No one assigned

Labels

>non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markjhoy @elasticsearchmachine @ioanatia @mromaios