Do not pack non-dimension fields in TS #138929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
reviewed
Dec 2, 2025
| assertThat(actualAvg, closeTo(expectedAvg, 0.5)); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Shall we add a test with grouping on a multi-value label (non-dimension)? It'll unroll, this is ok.
Member
Author
There was a problem hiding this comment.
Good point. I will make the project a multi-valued field.
kkrik-es
approved these changes
Dec 2, 2025
dnhatn
force-pushed
the
fix-pack-dimensions
branch
from
8d688ac to
094633e
Compare
dnhatn
added
:StorageEngine/ES|QL
Collaborator
|
Hi @dnhatn, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Member
Author
|
Thanks Kostas! |
Collaborator
💚 Backport successful
|
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Dec 2, 2025
We accidentally pack non-dimension fields when translating TS stats in elastic#136216. Relates elastic#136216
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally pack non-dimension fields when translating TS stats in #136216.
Relates #136216