Introduced Global checkpoints for Sequence Numbers #15485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasontedor I fixed the issue we ran into yesterday where the a primary relocation target started updating the global checkpoint too early |
| @Override | ||
| public void handleResponse(TransportResponse.Empty vResponse) { | ||
| onReplicaSuccess(); | ||
| transportService.sendRequest(node, transportReplicaAction, replicaRequest, transportOptions, new TransportResponseHandler<ShardResponse>() { |
There was a problem hiding this comment.
Nit: the indentation is off throughout the body of the anonymous implementation of TransportRequestHandler<ShardResponse> here.
|
|
||
| /** | ||
| * A shard component that is responsible of tracking the global checkpoint. The global checkpoint | ||
| * is the highest seq_no for which all lower (or equal) seq no have been process on all shards that |
There was a problem hiding this comment.
Nit: "seq no" -> "seq_no" (inconsistencies will make searching more difficult)
There was a problem hiding this comment.
Nit: "process" -> "processed"
|
Since this has gone through a few rounds of review before, I largely have the same thoughts I had then. I gave it a thorough re-read and left some comments. |
|
@jasontedor thx for the review. I pushed another commit addressing it. |
|
LGTM. |
clintongormley
added
:Engine
:Distributed Indexing/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR for introducing Global Checkpoints into the feature/seq_no branch. I made it to get some feedback before things are finalized / cycles are spent on docs etc. It is fairly solid, but a couple of things miss: