Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent closing index during snapshot restore #16933

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Mar 3, 2016

Closing an index that is being restored from a snapshot should fail the close operation. The previous behavior would close the index and the snapshot process would continue running indefinitely.

Relates to #16321

}
}

public void waitForBlockOnAnyDataNode(String repository, TimeValue timeout) throws InterruptedException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use awaitBusy here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. I have switched to awaitBusy here.

@imotov
Copy link
Contributor

imotov commented Mar 7, 2016

Left a minor comment. Otherwise, LGTM.

@ywelsch ywelsch force-pushed the fix/snaprestore-fails-close branch from edac4c5 to 71ac12f Compare March 8, 2016 11:04
ywelsch added a commit that referenced this pull request Mar 8, 2016
Prevent closing index during snapshot restore
@ywelsch ywelsch merged commit 20f5255 into elastic:master Mar 8, 2016
ywelsch added a commit that referenced this pull request Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v2.3.0 v5.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants