ParseFieldMatcher should log when using deprecated settings. #16988
+59
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>bug
:Core/Infra/Logging
| assertThat(withDeprecations.match(randomFrom(values), true), is(true)); | ||
| assertThat(withDeprecations.match("foo bar", true), is(false)); | ||
| expectThrows(IllegalArgumentException.class, () -> withDeprecations.match(randomFrom(deprecated), true)); | ||
| expectThrows(IllegalArgumentException.class, () -> withDeprecations.match("barFoo", true)); |
There was a problem hiding this comment.
It would be good to check part of the message for these expectThrows to be sure it is not some other IAE?
|
Looks good, one suggestion with the tests. |
…16988 I always thought ParseFieldMatcher would log when using a deprecated setting, but it does not.
jpountz
force-pushed
the
fix/parse_field_log
branch
from
a127d32 to
026519e
Compare
jpountz
added a commit
that referenced
this pull request
Mar 8, 2016
I always thought ParseFieldMatcher would log when using a deprecated setting, but it does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always thought ParseFieldMatcher would log when using a deprecated setting,
but it does not.