Extend field stats to report searchable/aggregatable fields #17980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>feature
v5.0.0-alpha2
:Data Management/Stats
| final static String MAX_DOC = new String("max_doc"); | ||
| final static String DOC_COUNT = new String("doc_count"); | ||
| final static String DENSITY = new String("density"); | ||
| final static String SUM_DOC_FREQ = new String("sum_doc_freq"); | ||
| final static String SUM_TOTAL_TERM_FREQ = new String("sum_total_term_freq"); | ||
| final static String IS_SEARCHABLE = new String("is_searchable"); | ||
| final static String IS_AGGREGATABLE = new String("is_aggregatable"); |
There was a problem hiding this comment.
should it be just searchable/aggregatable (without the is_ prefix) as suggested in the original issue?
There was a problem hiding this comment.
on the other hand I would agree to keep isSearchable/isAggregatable in the Java API
|
I left some comments but I think this is close! |
|
Thanks @jpountz I've pushed another commit. |
|
I left another comment regarding the visibility of these new isSearchable/isAggregatable methods. Otherwise it looks good to me. |
* Add isSearchable and isAggregatable (collapsed to true if any of the instances of that field are searchable or aggregatable). * Accept wildcards in field names. * Add a section named conflicts for fields with the same name but with incompatible types (instead of throwing an exception).
clintongormley
changed the title
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 15, 2016
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 16, 2016
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #17750