Enable Netty 4 extensions #19767
Merged
Enable Netty 4 extensions #19767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the Netty 4 HTTP server implementation to allow for extensions.
The Netty 4 transport implementations have an unnecessary dependency on SocketChannels, and can instead just use plain Channels.
jasontedor
added
>enhancement
review
:Distributed Coordination/Network
| serverBootstraps.put(name, serverBootstrap); | ||
| } | ||
|
|
||
| protected ChannelHandler getServerChannelInitializer(String name, Settings settings) { |
There was a problem hiding this comment.
is there a reason not to inline this method and the one below?
Member
Author
There was a problem hiding this comment.
Yes, to enable extensions.
There was a problem hiding this comment.
Discussed this with @jasontedor, he explained that this class can be extended and these methods need to be overridable.
Member
There was a problem hiding this comment.
shall we document the fact that these methods can be extended?
|
LGTM |
* master: Fix REST test documentation [Test] move methods from bwc test to test package for use in plugins (elastic#19738) package-info.java should be in src/main only. Split regular histograms from date histograms. elastic#19551 Tighten up concurrent store metadata listing and engine writes (elastic#19684) Plugins: Make NamedWriteableRegistry immutable and add extenion point for named writeables Add documentation for the 'elasticsearch-translog' tool [TEST] Increase time waiting for all shards to move off/on to a node Fixes the active shard count check in the case of (elastic#19760) Fixes cat tasks operation in detailed mode ignore some docker craziness in scccomp environment checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables some extensions to the Netty 4 implementation.
Relates #19526