Fix example in documentation for Painless using _source #21322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>bug
:Core/Infra/Scripting
nik9000
reviewed
Nov 3, 2016
| @@ -50,7 +50,7 @@ GET /_search | |||
| }, | |||
| "script_fields" : { | |||
| "test1" : { | |||
| "script" : "_source.obj1.obj2" | |||
| "script" : "params._source.obj1.obj2" | |||
There was a problem hiding this comment.
Ooh! If you add // TEST[setup:twitter] then below // CONSOLE on this page then we'll actually try an execute the script which might be nice.
There was a problem hiding this comment.
Will do... do you mind pointing me to an existing example? Thanks in advance.
There was a problem hiding this comment.
Have a look at misc.asciidoc. That shows both that you can just execute some code (top snippet) and that you can execute some code and check the results (bottom two snippets together).
nik9000
removed
the
:Core/Infra/Scripting
|
Oops! Let this one slip through the cracks. Going to finish it now. |
rjernst
approved these changes
Mar 16, 2017
| extract specific elements to be returned from it (can be an "object" | ||
| type). Here is an example: | ||
| Script fields can also access the actual `_source` document and | ||
| extract specific elements to be returned from it by using `params._source`. |
There was a problem hiding this comment.
Can you change this to params['_source']?
There was a problem hiding this comment.
Good catch. Fixed.
|
@rjernst Thanks for the review! |
jdconrad
added a commit
that referenced
this pull request
Mar 16, 2017
jdconrad
added a commit
that referenced
this pull request
Mar 16, 2017
jdconrad
added a commit
that referenced
this pull request
Mar 16, 2017
jdconrad
added a commit
that referenced
this pull request
Mar 16, 2017
jdconrad
added a commit
that referenced
this pull request
Mar 16, 2017
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 17, 2017
* master: Clear the interrupt flag before joining Migrate to max line length of 100 Docs: Corrected path to elasticsearch-plugin (elastic#23622) Docs: Add comma to reverse nested agg snippet Fix third-party audit task for Gradle 3.4 (elastic#23612) Adapter action future should restore interrupts Update scripting.asciidoc Unmark reindex as experimental CompletionSuggestionContext#toQuery() should also consider text if prefix/regex missing (elastic#23451) Docs: Specify that byte units use powers of 1024 (elastic#23574) Remove Settings.settingsBuilder (elastic#23575) Change params._source to params['_source'] in example. Fix example in documentation for Painless using _source. (elastic#21322) Remove extra line from license header Fix num docs to be positive in bucket deferring collector test Mapping: Fix NPE with scaled floats stats when field is not indexed (elastic#23528)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 17, 2017
* single-node-discovery: Clear the interrupt flag before joining Migrate to max line length of 100 Docs: Corrected path to elasticsearch-plugin (elastic#23622) Docs: Add comma to reverse nested agg snippet Fix third-party audit task for Gradle 3.4 (elastic#23612) Adapter action future should restore interrupts Update scripting.asciidoc Unmark reindex as experimental CompletionSuggestionContext#toQuery() should also consider text if prefix/regex missing (elastic#23451) Docs: Specify that byte units use powers of 1024 (elastic#23574) Remove Settings.settingsBuilder (elastic#23575) Change params._source to params['_source'] in example. Fix example in documentation for Painless using _source. (elastic#21322) Remove extra line from license header Fix num docs to be positive in bucket deferring collector test Mapping: Fix NPE with scaled floats stats when field is not indexed (elastic#23528)
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.