Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test coverage of aggs #22668

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Improve unit test coverage of aggs #22668

merged 1 commit into from
Jan 18, 2017
+367 −29

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jan 17, 2017

Add tests for GlobalAggregator, MaxAggregator, and InternalMax.

Relates to #22278

@nik9000
Improve unit test coverage of aggs
dd0c180 
Add tests for `GlobalAggregator`, `MaxAggregator`, and `InternalMax`.

Relates to elastic#22278
@nik9000 nik9000 added :Analytics/Aggregations Aggregations review >test Issues or PRs that are addressing/adding tests v5.3.0 v6.0.0-alpha1 labels Jan 17, 2017
@nik9000 nik9000 requested a review from martijnvg January 17, 2017 23:31
martijnvg
martijnvg approved these changes Jan 18, 2017
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000
Copy link
Member Author

nik9000 commented Jan 18, 2017

LGTM

Thanks for reviewing!

@s1monw
Copy link
Contributor

s1monw commented Jan 18, 2017

thanks so much for this @nik9000

@nik9000 nik9000 merged commit e71b26f into elastic:master Jan 18, 2017
@nik9000
Copy link
Member Author

nik9000 commented Jan 18, 2017 •
edited
Loading

master: e71b26f
5.x: nope. missing dependency make backport difficult.

@nik9000 nik9000 removed the v5.3.0 label Jan 18, 2017
@martijnvg martijnvg mentioned this pull request Jan 18, 2017
Closed
63 tasks
@tlrx tlrx mentioned this pull request Jan 23, 2017
Merged
javanna pushed a commit to javanna/elasticsearch that referenced this pull request May 23, 2017
@nik9000 @javanna
[TEST] backport InternalAggregationTestCase
ae18c2e 
Note that it only extends ESTestCase, it will be used for fromXContent tests only in 5.x

This is a partial backport of elastic#22668
@javanna javanna mentioned this pull request May 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v6.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik9000 @s1monw @martijnvg