Duplicate snapshot name throws InvalidSnapshotNameException #22921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create a snapshot with a name that already exists in the repository. Instead of throwing a SnapshotCreateException, which results in a generic 500 status code, a duplicate snapshot name will throw a InvalidSnapshotNameException, which will result in a 400 status code (bad request).
abeyad
added
:Distributed Coordination/Snapshot/Restore
Contributor
|
How about using 409 CONFLICT instead? |
Author
|
@clintongormley I thought about that but then I noticed in our WDYT? |
Contributor
|
OK, let's stick with 400 for now until we have time to review in more depth |
Author
|
thanks @imotov |
abeyad
pushed a commit
that referenced
this pull request
Feb 6, 2017
create a snapshot with a name that already exists in the repository. Instead of throwing a SnapshotCreateException, which results in a generic 500 status code, a duplicate snapshot name will throw a InvalidSnapshotNameException, which will result in a 400 status code (bad request).
Author
|
5.x commit: 6f14949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the exception type thrown when trying to
create a snapshot with a name that already exists in the repository.
Instead of throwing a SnapshotCreateException, which results in a
generic 500 status code, a duplicate snapshot name will throw a
InvalidSnapshotNameException, which will result in a 400 status code
(bad request).
Note that before 5.0, a duplicate snapshot name would throw an
InvalidSnapshotNameException. After #18228, the exception type was
inadvertently changed.