Improve setting deprecation message #23156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the deprecation log message emitted when a setting is found which is deprecated. The new message indicates docs for the deprecated settings can be found in the breaking changes docs for the next major version. closes elastic#22849
rjernst
added
:Core/Infra/Settings
dadoonet
approved these changes
Feb 14, 2017
Contributor
dadoonet
left a comment
dadoonet
left a comment
There was a problem hiding this comment.
I'm wondering if we can generate automatically the link to the next major version doc. May be it's too much though.
clintongormley
approved these changes
Feb 14, 2017
Contributor
|
LGTM2 |
rjernst
added a commit
that referenced
this pull request
Feb 15, 2017
This change modifies the deprecation log message emitted when a setting is found which is deprecated. The new message indicates docs for the deprecated settings can be found in the breaking changes docs for the next major version. closes #22849
rjernst
added a commit
that referenced
this pull request
Feb 15, 2017
This change modifies the deprecation log message emitted when a setting is found which is deprecated. The new message indicates docs for the deprecated settings can be found in the breaking changes docs for the next major version. closes #22849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the deprecation log message emitted when a setting
is found which is deprecated. The new message indicates docs for the
deprecated settings can be found in the breaking changes docs for the
next major version.
closes #22849