Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for BinaryRangeAggregator/InternalBinaryRange #23255

Merged
merged 3 commits into from
Feb 20, 2017
Merged

Add unit tests for BinaryRangeAggregator/InternalBinaryRange #23255

merged 3 commits into from
Feb 20, 2017

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Feb 20, 2017

Relates #22278

@jimczi jimczi added :Analytics/Aggregations Aggregations :Aliases help wanted adoptme >test Issues or PRs that are addressing/adding tests v6.0.0-alpha1 and removed :Aliases help wanted adoptme labels Feb 20, 2017
jpountz
jpountz approved these changes Feb 20, 2017
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the hashcode impl, otherwise LGTM.

core/src/main/java/org/elasticsearch/search/aggregations/bucket/range/InternalBinaryRange.java Outdated

@Override
public int hashCode() {
return Objects.hash(keyed, format, docCount, key, from, to, aggregations);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyed and format are in the hashcode but not in equals. I think it is fine not to consider them in equals since they only have an impact on formatting, but then hashCode should not use them either?

@jpountz
Copy link
Contributor

jpountz commented Feb 20, 2017

LGTM

@jimczi jimczi merged commit 69b1463 into elastic:master Feb 20, 2017
@jimczi jimczi deleted the ip_range_test branch February 20, 2017 10:55
@martijnvg martijnvg mentioned this pull request Feb 20, 2017
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v6.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimczi @jpountz