Removes the retry mechanism from the S3 blob store #23952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 6, 2017 15:06
Currently, both the Amazon S3 client provides a retry mechanism, and the S3 blob store also attempts retries for failed read/write requests. Both retry mechanisms are controlled by the `repositories.s3.max_retries` setting. However, the S3 blob store retry mechanism is unnecessary because the Amazon S3 client provided by the Amazon SDK already handles retries (with exponential backoff) based on the provided max retry configuration setting (defaults to 3) as long as the request is retryable. Hence, this commit removes the unneeded retry logic in the S3 blob store and the S3OutputStream. Closes elastic#22845
abeyad
added
:Plugin Repository S3
:Distributed Coordination/Snapshot/Restore
rjernst
approved these changes
Apr 6, 2017
| @@ -340,7 +340,7 @@ The default behaviour is to detect which access style to use based on the config | |||
| storageClass, pathStyleAccess); | |||
|
|
|||
| AmazonS3 client = s3Service.client(metadata.settings(), maxRetries, useThrottleRetries, pathStyleAccess); | |||
| blobStore = new S3BlobStore(settings, client, bucket, serverSideEncryption, bufferSize, maxRetries, cannedACL, storageClass); | |||
There was a problem hiding this comment.
maxRetries is now just used for logging above, which I don't think is necessary, or should not be done here. I think reading that setting can be moved down into building the client?
|
Still LGTM. |
|
thanks for the review @rjernst |
abeyad
pushed a commit
that referenced
this pull request
Apr 7, 2017
Currently, both the Amazon S3 client provides a retry mechanism, and the S3 blob store also attempts retries for failed read/write requests. Both retry mechanisms are controlled by the `repositories.s3.max_retries` setting. However, the S3 blob store retry mechanism is unnecessary because the Amazon S3 client provided by the Amazon SDK already handles retries (with exponential backoff) based on the provided max retry configuration setting (defaults to 3) as long as the request is retryable. Hence, this commit removes the unneeded retry logic in the S3 blob store and the S3OutputStream. Closes #22845
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both the Amazon S3 client provides a retry mechanism, and the
S3 blob store also attempts retries for failed read/write requests.
Both retry mechanisms are controlled by the
repositories.s3.max_retriessetting. However, the S3 blob store retrymechanism is unnecessary because the Amazon S3 client provided by the
Amazon SDK already handles retries (with exponential backoff) based on
the provided max retry configuration setting (defaults to 3) as long as
the request is retryable. Hence, this commit removes the unneeded retry
logic in the S3 blob store and the S3OutputStream.
Closes #22845