Upgrade to a Lucene 7 snapshot #24089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2941f21.
This is until we can work out what to do with LeafSearchLookup which seeks to the document on multiple things each of which may or may not have values for the document but also may or may not be used by the running script
Does not fix errors in ScriptDocValues
jpountz
added
:Core/Infra/Core
Member
|
@jpountz shouldn't the label be "v6.0.0" instead of "v7.0.0"? |
Contributor
Author
|
Thanks @danielmitterdorfer, indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to upgrade to Lucene 7 ahead of time in order to be able to check whether it causes any trouble to Elasticsearch before Lucene 7.0 gets released. From a user perspective, the main benefit of this upgrade is the enhanced support for sparse fields, whose resource consumption is now function of the number of docs that have a value rather than the total number of docs in the index.
Some notes about the change:
disable_coordparameter of theboolandcommon_termsqueries: Lucene has removed support for coord factorsindex.similarity.baseexpert setting, since it was only useful to configure coords and query norms, which have both been removed@AwaitsFixbecause of query_string and simple_query_string cannot apply minimum should match consistently #23966, which we intend to address after the mergeWe tried to take the shorter path that got us to something that would be mergeable, but there are still many things to clean up, I started opening some issues: #24088, #24087, #24086.