Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for cluster to become quiescent between REST tests #24148

Merged
merged 2 commits into from
Apr 19, 2017

Conversation

abeyad
Copy link

@abeyad abeyad commented Apr 18, 2017

[TEST] ensures REST tests wait for cluster state updates to finish
processing before moving to the next test

processing before moving to the next test
@abeyad abeyad added >enhancement review >test Issues or PRs that are addressing/adding tests labels Apr 18, 2017
@abeyad abeyad requested a review from rjernst April 18, 2017 03:31
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javanna
Copy link
Member

javanna commented Apr 18, 2017

hey @abeyad could you clarify why this is needed? I guess there were build failures around this? I am particularly interested in whether this should have been there forever or some recent change required this new check between tests. Thanks!

@abeyad
Copy link
Author

abeyad commented Apr 18, 2017

hey @javanna, this was the result of a test failure that had to do with the fact that one of the "wait for active shard" tests had a very short timeout to process a cluster state event (because we expect it to fail). The problem is, it couldn't even get to the timeout phase because there was a cluster state update that failed to be processed and was potentially interfering with all subsequent tests. So the idea here is to make sure all cluster state updates have been processed in a test REST test run before moving on to the next test. Does that help clarify?

@javanna
Copy link
Member

javanna commented Apr 19, 2017

thanks for explaining @abeyad

@abeyad abeyad merged commit 3c82eea into elastic:master Apr 19, 2017
@abeyad abeyad deleted the tests_wait_for_quiet_cluster branch April 19, 2017 17:17
@abeyad
Copy link
Author

abeyad commented Apr 19, 2017

thanks for the review @rjernst

abeyad pushed a commit that referenced this pull request Apr 19, 2017
[TEST] ensures REST tests wait for cluster state updates to finish
processing before moving to the next test
abeyad pushed a commit that referenced this pull request Apr 19, 2017
[TEST] ensures REST tests wait for cluster state updates to finish
processing before moving to the next test
abeyad pushed a commit that referenced this pull request Apr 19, 2017
[TEST] ensures REST tests wait for cluster state updates to finish
processing before moving to the next test
@abeyad
Copy link
Author

abeyad commented Apr 19, 2017

5.x commit: bbcb580
5.4 commit: 09fe5e3
5.3 commit: 035709b

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 19, 2017
* master:
  Wait for cluster to become quiescent between REST tests (elastic#24148)
  Plugins: Remove leniency for missing plugins dir (elastic#24173)
  Changing some grammar in docs (elastic#24164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants