-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for cluster to become quiescent between REST tests #24148
Conversation
processing before moving to the next test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hey @abeyad could you clarify why this is needed? I guess there were build failures around this? I am particularly interested in whether this should have been there forever or some recent change required this new check between tests. Thanks! |
hey @javanna, this was the result of a test failure that had to do with the fact that one of the "wait for active shard" tests had a very short timeout to process a cluster state event (because we expect it to fail). The problem is, it couldn't even get to the timeout phase because there was a cluster state update that failed to be processed and was potentially interfering with all subsequent tests. So the idea here is to make sure all cluster state updates have been processed in a test REST test run before moving on to the next test. Does that help clarify? |
thanks for explaining @abeyad |
thanks for the review @rjernst |
[TEST] ensures REST tests wait for cluster state updates to finish processing before moving to the next test
[TEST] ensures REST tests wait for cluster state updates to finish processing before moving to the next test
[TEST] ensures REST tests wait for cluster state updates to finish processing before moving to the next test
* master: Wait for cluster to become quiescent between REST tests (elastic#24148) Plugins: Remove leniency for missing plugins dir (elastic#24173) Changing some grammar in docs (elastic#24164)
[TEST] ensures REST tests wait for cluster state updates to finish
processing before moving to the next test