Skip to content

Remove the unused SignificantTerms.compareTerm() method #24714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlrx merged 1 commit into from
May 18, 2017
Merged

Remove the unused SignificantTerms.compareTerm() method #24714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...n/java/org/elasticsearch/search/aggregations/bucket/significant/SignificantLongTerms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,6 @@ public Object getKey() {
return term;
}

@Override
public int compareTerm(SignificantTerms.Bucket other) {
return Long.compare(term, ((Number) other.getKey()).longValue());
}

@Override
public String getKeyAsString() {
return format.format(term);
Expand Down
6 changes: 0 additions & 6 deletions ...java/org/elasticsearch/search/aggregations/bucket/significant/SignificantStringTerms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import org.elasticsearch.search.aggregations.pipeline.PipelineAggregator;

import java.io.IOException;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Objects;
Expand Down Expand Up @@ -82,11 +81,6 @@ public Number getKeyAsNumber() {
return Double.parseDouble(termBytes.utf8ToString());
}

@Override
public int compareTerm(SignificantTerms.Bucket other) {
return termBytes.compareTo(((Bucket) other).termBytes);
}

@Override
public String getKeyAsString() {
return format.format(termBytes);
Expand Down
2 changes: 0 additions & 2 deletions .../main/java/org/elasticsearch/search/aggregations/bucket/significant/SignificantTerms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ interface Bucket extends MultiBucketsAggregation.Bucket {
long getSupersetSize();

long getSubsetSize();

int compareTerm(SignificantTerms.Bucket other);
}

@Override
Expand Down