Add parsing method for Top Hits aggregation #24717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 tasks
javanna
approved these changes
May 17, 2017
cbuescher
reviewed
May 17, 2017
Member
There was a problem hiding this comment.
Luca mentioned in another PR that we might not need the need @bfore here since the parent method already has it.
Member
There was a problem hiding this comment.
Can you explain why we need to sort here? I thought hits is an array, so we should parse back the hits in the same order as in the original object, or do I miss something?
Member
There was a problem hiding this comment.
good point I am curious too now :) I hadn't noticed this at first
Member
Author
There was a problem hiding this comment.
That's a leftover, this is indeed not necessary. Thanks for catching it Christoph!
tlrx
force-pushed
the
add-parsing-top-hits
branch
from
469552f to
23cc872
Compare
Member
Author
|
Thanks @javanna @cbuescher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the parsing logic for the InternalTopHits aggregation.