IllegalStateException: Only duplicated jar instead of classpath #24953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Member
|
I see the point about making it easier to see the duplicate jar, but I would prefer that we not suppress the entire classpath here. Would you mind pushing a change the shows the duplicate jar and the entire classpath? Something like: |
jasontedor
requested changes
May 30, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left a comment at the top level about changing the method to still include the entire classpath.
Contributor
Author
|
@jasontedor, updated |
Member
|
test this please |
Member
|
Thanks @s12v, I've started a CI build. |
* master: (62 commits) Handle already closed while filling gaps [DOCS] Clarify behaviour of scripted-metric arg with empty parent buckets [DOCS] Clarify connections and gateway nodes selection in cross cluster search docs (elastic#24859) Java api: Remove unneeded getTookInMillis method (elastic#23923) Adds nodes usage API to monitor usages of actions (elastic#24169) Add superset size to Significant Term REST response (elastic#24865) Disallow multiple parent-join fields per mapping (elastic#25002) [Test] Remove unused test resources in core (elastic#25011) Scripting: Add optional context parameter to put stored script requests (elastic#25014) Extract a common base class for scroll executions (elastic#24979) Build: fix version sorting Build: Move verifyVersions to new branchConsistency task (elastic#25009) Add backwards compatibility indices Build: improve verifyVersions error message (elastic#25006) Add version 5.4.2 constant Docs: More search speed advices. (elastic#24802) Add version 5.3.3 constant Reorganize docs of global ordinals. (elastic#24982) Provide the TransportRequest during validation of a search context (elastic#24985) [TEST] fix SearchIT assertion to also accept took set to 0 ...
Member
|
retest this please |
Contributor
Author
|
@jasontedor, there's a typo, sorry. Fixed, could you please retest it? |
Member
|
retest this please |
jasontedor
pushed a commit
that referenced
this pull request
Jun 2, 2017
When the jarhell check fails due to a duplicate jar on the classpath, the exception message includes the full classpath but not the duplicated jar. For a long classpath, this can make it difficult to find the jar that is duplicated. This commit changes the exception message to include the duplicated jar. Relates #24953
Member
|
Thanks @s12v! |
clintongormley
added
:Exceptions
>enhancement
v6.0.0
v5.5.0
v6.0.0-alpha2
and removed
v6.0.0
v6.0.0-alpha2
labels
lcawl
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, entire classpath is in exception message, which is not very helpful:
After the change, only problematic jar should be included in the message.