Forward compatibility for primary context handoff on 6.x #25545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleskes
approved these changes
Jul 6, 2017
| @@ -293,6 +294,14 @@ public void onResponse(PrimaryShardReference primaryShardReference) { | |||
| final ShardRouting primary = primaryShardReference.routingEntry(); | |||
| assert primary.relocating() : "indexShard is marked as relocated but routing isn't" + primary; | |||
| DiscoveryNode relocatingNode = clusterService.state().nodes().get(primary.relocatingNodeId()); | |||
| if (relocatingNode != null && relocatingNode.getVersion().major > Version.CURRENT.major) { | |||
| // ES 6.x requires a primary context hand-off during primary relocation which is not implemented on ES 5.x. | |||
There was a problem hiding this comment.
can add a sentence or two about what is currently known to be potentially missing? (in sync markers for shards on new nodes that should be accounted for GP calculations). I think it will help (at least it would me) to understand what this is about.
jasontedor
approved these changes
Jul 6, 2017
There was a problem hiding this comment.
LGTM modulo elaborating on the comment as @bleskes suggested.
clintongormley
added
:Distributed Indexing/Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for #25468