Skip to content

Remove unused searcher parameter in SearchService#createContext #27227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
s1monw merged 1 commit into from
Nov 2, 2017
Merged

Remove unused searcher parameter in SearchService#createContext #27227

s1monw merged 1 commit into from
Nov 2, 2017

Conversation

@s1monw
Copy link
Contributor

@s1monw s1monw commented Nov 2, 2017

This parameter isn't used anywhere and just adds complexity.

@s1monw
Remove unused searcher parameter in SearchService#createContext
2c321d4 
This parameter isn't used anywhere and just adds complexity.
@s1monw s1monw added :Search/Search Search-related issues that do not fall into other categories >non-issue v6.1.0 v7.0.0 labels Nov 2, 2017
@s1monw s1monw requested review from javanna and jimczi November 2, 2017 09:51
javanna
javanna approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jimczi
jimczi approved these changes Nov 2, 2017
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to use this to force a specific searcher on a context for #26472 but it can be reintroduced if we think it's the right way to do it. So LGTM and we can revisit later.

@s1monw s1monw merged commit b294250 into elastic:master Nov 2, 2017
s1monw added a commit that referenced this pull request Nov 2, 2017
@s1monw
Remove unused searcher parameter in SearchService#createContext (#27227)
f2aa6d0 
This parameter isn't used anywhere and just adds complexity.
martijnvg added a commit that referenced this pull request Nov 3, 2017
@martijnvg
Merge branch 'master' into ccr
0289330 
* master:
  Fixed byte buffer leak in Netty4 request handler
  Avoid uid creation in ParsedDocument (#27241)
  Rander sum as zero if count is zero for stats aggregation (#26893) (#27193)
  Add additional explanations around discovery.zen.ping_timeout (#27231)
  Remove unused searcher parameter in SearchService#createContext (#27227)
  Upgrade to Lucene 7.1 (#27225)
  Move IndexShard#getWritingBytes() under InternalEngine (#27209)
  Adjust bwc version for exists query tests
  Introducing took time for _msearch
martijnvg added a commit that referenced this pull request Nov 3, 2017
@martijnvg
Merge branch '6.x' into ccr-6.x
1166c19 
* 6.x:
  Fixed byte buffer leak in Netty4 request handler
  Avoid uid creation in ParsedDocument (#27241)
  Upgrade to Lucene 7.1 (#27225)
  Add additional explanations around discovery.zen.ping_timeout (#27231)
  Fix compile error
  Remove unused searcher parameter in SearchService#createContext (#27227)
  Fix sequence number assertions in BWC tests
  Move IndexShard#getWritingBytes() under InternalEngine (#27209)
  Adjust bwc version for exists query tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javanna javanna javanna approved these changes

@jimczi jimczi jimczi approved these changes

Assignees

No one assigned

Labels

>non-issue :Search/Search Search-related issues that do not fall into other categories v6.1.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@s1monw @javanna @jimczi @colings86