Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused *Commit* classes #27714

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Remove unused *Commit* classes #27714

merged 1 commit into from
Dec 8, 2017

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Dec 8, 2017

These *Commit* classes are not used anywhere.

Relates #27606

These classes are not used anywhere.

Relates elastic#27606
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code is good code. Removed dead code is the best code. LGTM.

@dnhatn
Copy link
Member Author

dnhatn commented Dec 8, 2017

Thank you @jasontedor for your quick review :).

@dnhatn dnhatn merged commit 6efee32 into elastic:master Dec 8, 2017
@dnhatn dnhatn deleted the unused-code branch December 8, 2017 02:42
dnhatn added a commit that referenced this pull request Dec 8, 2017
These classes are not used anywhere.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 8, 2017
* master:
  Fix routing with leading or trailing whitespace
  remove await fix from FullClusterRestartIT.testRecovery
  Add missing 's' to tmpdir name (elastic#27721)
  [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (elastic#27717)
  [TEST] Now actually wait for merges
  Test out of order delivery of append only index and retry with an intermediate delete
  [TEST] remove code duplications in RequestTests
  [Tests] Add test for GeoShapeFieldType#setStrategyName (elastic#27703)
  Remove unused *Commit* classes (elastic#27714)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 8, 2017
* master: (414 commits)
  Set ACK timeout on indices service test
  Implement byte array reusage in `NioTransport` (elastic#27696)
  [TEST] Remove leftover ES temp directories before Vagrant tests (elastic#27722)
  Cleanup split strings by comma method
  Remove unused import from AliasResolveRoutingIT
  Add read timeouts to http module (elastic#27713)
  Fix routing with leading or trailing whitespace
  remove await fix from FullClusterRestartIT.testRecovery
  Add missing 's' to tmpdir name (elastic#27721)
  [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (elastic#27717)
  [TEST] Now actually wait for merges
  Test out of order delivery of append only index and retry with an intermediate delete
  [TEST] remove code duplications in RequestTests
  [Tests] Add test for GeoShapeFieldType#setStrategyName (elastic#27703)
  Remove unused *Commit* classes (elastic#27714)
  Add test for writer operation buffer accounting (elastic#27707)
  [TEST] Wait for merging to complete before testing breaker
  Add Open Index API to the high level REST client (elastic#27574)
  Correcting some minor typos in comments
  Add unreleased v5.6.6 version
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants