Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp and ttl in index requests #27888

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

codebrain
Copy link
Contributor

timestamp and ttl are not accepted anymore as parameters of index/update requests.

https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking_60_rest_changes.html

timestamp and ttl are not accepted anymore as parameters of index/update requests.
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dadoonet
Copy link
Member

That was documented in 5.0 breaking changes. See https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_mapping_changes.html#_literal__timestamp_literal_and_literal__ttl_literal

I don't think we should still talk about this in 6.0

@codebrain
Copy link
Contributor Author

No need to talk, just removing from the REST specification :)

@dadoonet
Copy link
Member

OMG! I should not look at PR when I'm just waking up. 🙄

@codebrain codebrain merged commit e458c6b into elastic:master Dec 19, 2017
codebrain pushed a commit that referenced this pull request Dec 19, 2017
timestamp and ttl are not accepted anymore as parameters of index/update requests.
codebrain pushed a commit that referenced this pull request Dec 19, 2017
timestamp and ttl are not accepted anymore as parameters of index/update requests.
codebrain pushed a commit that referenced this pull request Dec 19, 2017
timestamp and ttl are not accepted anymore as parameters of index/update requests.
@codebrain
Copy link
Contributor Author

Backported to 6.x, 6.0 and 6.1 branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants