Replace jvm-example by two plugin examples #28339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
reviewed
Jan 23, 2018
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
I like it! I left a single comment, but that comment is probably important.
tlrx
force-pushed
the
replace-jvm-example
branch
from
7d38358 to
7c0977f
Compare
Member
Author
tlrx
added a commit
that referenced
this pull request
Jan 26, 2018
This pull request replaces the jvm-example plugin (from the jvm/site plugins era) by two new plugins: a custom-settings that shows how to register and use custom settings (including secured settings) in a plugin, and rest-handler plugin that shows how to register a rest handler. The two plugins now reside in the plugins/examples project. They can serve as sample plugins for users, a special attention has been put on documentation. The packaging tests have been adapted to use the custom-settings plugin.
Collaborator
|
Pinging @elastic/es-core-infra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the
jvm-exampleplugin (from the jvm/site plugins era) by two new plugins: acustom-settingsthat shows how to register and use custom settings (including secured settings) in a plugin, andrest-handlerplugin that shows how to register a rest handler.The two plugins now reside in the
plugins/examplesproject. They can serve as sample plugins for users, a special attention has been put on documentation. The packaging tests have been adapted to use thecustom-settingsplugin.