Update to forbiddenapis 2.5

[uschindler]

This pull request updates forbiddenapis to version 2.5.

The new release supports Java 10 bytecode and also adds support for checking violations in commons-io-2.6.

While testing this I figured out one issue: You may pass -Drepos.mavenLocal=true to gradle, but this does not work globally. It will still complain about missing forbiddenapis (before it was on Maven Central). I was not able to fix this, because I have no idea what the if project==rootProject check should do. @rjernst ?

To support me in developing the Gradle Plugin of forbiddenapis, please add support for the above property. I also figured out that there are 2 sysprops: repos.mavenLocal and repos.mavenlocal, neither work: https://github.com/elastic/elasticsearch/search?utf8=%E2%9C%93&q=repos.mavenLocal

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[rjernst]

@elasticmachine test this please

[rjernst]

Thanks for this PR @uschindler.

there are 2 sysprops: repos.mavenLocal and repos.mavenlocal

This is a bug, I will fix.

I have no idea what the if project==rootProject check should do

This set of code under buildSrc is for "bootstrapping". We configure a (sort of) fake project called build-tools which points at the buildSrc directory. This allows us to not have to duplicate a lot of publication code for the code in buildSrc. Essentially, buildSrc/build.gradle is run twice. The first time, it is part of grade's bootstrapping, where it builds buildSrc. The second time, it is as the :build-tools project. Unfortunately the maven repos code must be in both places (specifically so mavenLocal can work in this case). I think fixing the casing should fix the problem you had.

[rjernst]

I opened #29289.

[rjernst]

Thanks @uschindler