-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the field capabilities API, deprecate support for providing fields in the request body. #30157
Merged
jtibshirani
merged 2 commits into
elastic:6.x
from
jtibshirani:refactor/field-caps-deprecation
Apr 26, 2018
Merged
In the field capabilities API, deprecate support for providing fields in the request body. #30157
jtibshirani
merged 2 commits into
elastic:6.x
from
jtibshirani:refactor/field-caps-deprecation
Apr 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>deprecation
v6.4.0
:Search/Search
Search-related issues that do not fall into other categories
labels
Apr 25, 2018
Pinging @elastic/es-search-aggs |
jimczi
approved these changes
Apr 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @jtibshirani
jtibshirani
force-pushed
the
refactor/field-caps-deprecation
branch
from
April 26, 2018 00:30
aaad7f4
to
79d2603
Compare
martijnvg
added a commit
that referenced
this pull request
Apr 26, 2018
* es/master: Watcher: Fold two smoke test projects into smoke-test-watcher (#30137) In the field capabilities API, deprecate support for providing fields in the request body. (#30157) Set JAVA_HOME before forking setup commands (#29647) Remove animal sniffer from low-level REST client (#29646) Cleanup .gitignore (#30145) Do not add noop from local translog to translog again (#29637) Build: Assert jar LICENSE and NOTICE files match Correct transport compression algorithm in docs (#29645) [Test] Fix docs check for DEB package in packaging tests (#30126) Painless: Docs Clean Up (#29592) Fixes Eclipse build for sql jdbc project (#30114) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (#29612)
martijnvg
added a commit
that referenced
this pull request
Apr 26, 2018
* es/6.x: In the field capabilities API, deprecate support for providing fields in the request body. (#30157) Set JAVA_HOME before forking setup commands (#29647) Remove animal sniffer from low-level REST client (#29646) Cleanup .gitignore (#30145) Do not add noop from local translog to translog again (#29637) Painless: Docs Clean Up (#29592) Build: Assert jar LICENSE and NOTICE files match Correct transport compression algorithm in docs (#29645) AwaitsFix for testGradleVersionsMatchVersionUtils [Test] Fix docs check for DEB package in packaging tests (#30126) Remove reference to `not_analyzed`. [Docs] Add community analysis plugin (#29612) [DOCS] Removed differencies between text and code (#27993)
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>deprecation
:Search/Search
Search-related issues that do not fall into other categories
v6.4.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #29664, we are deprecating the ability to provide
fields
in the request body in 6.4.0, and removing support in 7.0.0.