Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Removes redundant Active Directory realm settings #30190

Merged
merged 2 commits into from
Apr 30, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 26, 2018

This PR removes the redundant information about Active Directory realm settings from
https://www.elastic.co/guide/en/elastic-stack-overview/master/active-directory-realm.html
after integrating the missing information in
https://www.elastic.co/guide/en/elasticsearch/reference/master/security-settings.html#ref-ad-settings

@lcawl lcawl added >docs General docs changes v7.0.0 v6.3.0 :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v6.4.0 labels Apr 26, 2018
@lcawl lcawl requested a review from jaymode April 26, 2018 22:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

`url`::
A URL in the format `ldap[s]://<server>:<port>`. Defaults to `ldap://<domain_name>:389`.
An LDAP URL of the form `ldap[s]://<server>:<port>`. {security} attempts to
authenticate against this URL. If the URL is note specified, it is derived from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/note/not

pool. Connections are checked in the background at the specified interval.
Defaults to `true`.

`user_search.pool.health_check.dn`::
The distinguished name to be retrieved as part of the health check.
Defaults to the value of `bind_dn` if it is a distinguished name.
//TBD: The https://www.elastic.co/guide/en/x-pack/master/active-directory-realm.html#ad-settings said:
//Defaults to the value of bind_dn if present, and if not falls back to user_search.base_dn.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this longer comment is correct

@lcawl lcawl force-pushed the lcawley-adrealmsettings branch from d263ba6 to 8d6bb91 Compare April 30, 2018 15:29
@lcawl lcawl merged commit e95a7aa into elastic:master Apr 30, 2018
@lcawl lcawl deleted the lcawley-adrealmsettings branch April 30, 2018 15:52
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 1, 2018
* origin/master:
  [test] add java packaging test project (elastic#30161)
  Fix macros in changelog (elastic#30269)
  [DOCS] Fixes syskeygen command name
  [ML] Include 3rd party C++ component notices (elastic#30132)
  _cluster/state Skip Test for pre-6.4, not pre-7.0 (elastic#30264)
  Improve docs for disk watermarks (elastic#30249)
  [DOCS] Removes redundant Active Directory realm settings (elastic#30190)
  [DOCS] Removes redundant LDAP realm settings (elastic#30193)
  _cluster/state should always return cluster_uuid (elastic#30143)
  HTML5ify Javadoc for core and test framework (elastic#30234)
  Minor tweaks to reroute documentation (elastic#30246)
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v6.3.0 v6.4.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants