-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST high-level client: add validate query API #31077
Changes from 8 commits
6a6b61f
aad5341
7bcc283
53b0747
2d8f6b3
ed05533
8c9cb3c
e4da255
1677ed6
00e7169
c5095db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,7 @@ | |
import org.elasticsearch.action.admin.indices.shrink.ResizeType; | ||
import org.elasticsearch.action.admin.indices.template.get.GetIndexTemplatesRequest; | ||
import org.elasticsearch.action.admin.indices.template.put.PutIndexTemplateRequest; | ||
import org.elasticsearch.action.admin.indices.validate.query.ValidateQueryRequest; | ||
import org.elasticsearch.action.bulk.BulkRequest; | ||
import org.elasticsearch.action.delete.DeleteRequest; | ||
import org.elasticsearch.action.fieldcaps.FieldCapabilitiesRequest; | ||
|
@@ -856,6 +857,20 @@ static Request putTemplate(PutIndexTemplateRequest putIndexTemplateRequest) thro | |
return request; | ||
} | ||
|
||
static Request validateQuery(ValidateQueryRequest validateQueryRequest) throws IOException { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, thanks for catching this. |
||
String[] indices = validateQueryRequest.indices() == null ? Strings.EMPTY_ARRAY : validateQueryRequest.indices(); | ||
String[] types = validateQueryRequest.types() == null || indices.length <= 0 ? Strings.EMPTY_ARRAY : validateQueryRequest.types(); | ||
String endpoint = endpoint(indices, types, "_validate/query"); | ||
Request request = new Request(HttpGet.METHOD_NAME, endpoint); | ||
Params params = new Params(request); | ||
params.withIndicesOptions(validateQueryRequest.indicesOptions()); | ||
params.putParam("explain", Boolean.toString(validateQueryRequest.explain())); | ||
params.putParam("all_shards", Boolean.toString(validateQueryRequest.allShards())); | ||
params.putParam("rewrite", Boolean.toString(validateQueryRequest.rewrite())); | ||
request.setEntity(createEntity(validateQueryRequest, REQUEST_BODY_CONTENT_TYPE)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it looks like we might be missing a few more options such as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
return request; | ||
} | ||
|
||
static Request getAlias(GetAliasesRequest getAliasesRequest) { | ||
String[] indices = getAliasesRequest.indices() == null ? Strings.EMPTY_ARRAY : getAliasesRequest.indices(); | ||
String[] aliases = getAliasesRequest.aliases() == null ? Strings.EMPTY_ARRAY : getAliasesRequest.aliases(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add params tag like we have now in all of the other methods?