Change GeoHashGrid.Bucket#getKey() to return String #31748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
review
:Analytics/Aggregations
|
Pinging @elastic/es-search-aggs |
cbuescher
commented
Jul 2, 2018
| @@ -77,7 +77,7 @@ private static long longEncode(final String hash, int length) { | |||
| long b; | |||
| long l = 0L; | |||
| for(char c : hash.toCharArray()) { | |||
| b = (long)(BASE_32_STRING.indexOf(c)); | |||
| b = BASE_32_STRING.indexOf(c); | |||
There was a problem hiding this comment.
My IDE made me do it ;-) Can revert if it is confusing in this PR.
The GeoHashGrid bucket class currently returns a GeoPoint with its getKey() method. The REST API returns geohash as a String in the key field of the bucket. This changes the getKey() method to also return a String. Having the ability to get a GeoPoint from a bucket that represents a geohash cell is misleading because the cell does not represent a point but an area. Instead, it should be the clients responsibility to make the decision on how to represent the bucket key in its application. This also simplifies implementing the high level rest client aspects of elastic#30320, as the client will not need to know about the GeoHashType being used and will only care that there is some string key for the buckets. Relates to elastic#30320
cbuescher
force-pushed
the
change-geoHashGrid-getKey
branch
from
504ef9a to
0349b62
Compare
|
@colings86 could you take a look if this is enough to close #31748? I was looking at a way to deprecate sth. here but since the method signature is "Object getKey()" in |
3 tasks
|
Closing, as there is a separate plan now: #30320 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GeoHashGrid bucket class currently returns a GeoPoint with its getKey()
method. The REST API returns geohash as a String in the key field of the bucket.
This changes the getKey() method to also return a String. Having the ability to
get a GeoPoint from a bucket that represents a geohash cell is misleading
because the cell does not represent a point but an area. Instead, it should be
the clients responsibility to make the decision on how to represent the bucket
key in its application. This also simplifies implementing the high level rest
client aspects of #30320, as the client will not need to know about the
GeoHashType being used and will only care that there is some string key for the
buckets.
Relates to #30320