SQL: Bug fix for the optional "start" parameter usage inside LOCATE function #32576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used, leading to the incorrect constructor being used. Fixes elastic#32554
|
Pinging @elastic/es-search-aggs |
nik9000
reviewed
Aug 2, 2018
| @@ -85,6 +85,10 @@ public final void collectFields(SqlSourceBuilder sourceBuilder) { | |||
|
|
|||
| @Override | |||
| protected NodeInfo<LocateFunctionProcessorDefinition> info() { | |||
| if (start == null) { | |||
| return NodeInfo.create(this, LocateFunctionProcessorDefinition::new, expression(), pattern, source); | |||
There was a problem hiding this comment.
Hmmmm. I think it might be less error prone if only have the one constructor for LocateFunctionProcessorDefinition. Is that possible?
There was a problem hiding this comment.
@nik9000 I know I already tried this as a first option when I started implementing these, but I don't remember why it didn't work out. I think it was about the same reason: null children in the constructor. I'll revisit, maybe I'll find another way.
There was a problem hiding this comment.
If that funny test gets in your way then ping me! I think I can help work around it.....
|
@nik9000 I've simplified this by using one constructor. Tests passed so far. Let me know your thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect
NodeInfois created when the optional parameter is not used, leading to the incorrect constructor being used.Fixes #32554