HLRC: split cluster request converters #33400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to encapsulate the different clients, the request converters are being shuffled around. This splits the ClusterClient request converters.
Collaborator
|
Pinging @elastic/es-core-infra |
hub-cap
commented
Sep 4, 2018
| request.persistentSettings(persistentSettings); | ||
| request.transientSettings(transientSettings); | ||
| assertOK(client().performRequest(RequestConverters.clusterPutSettings(request))); | ||
| assertTrue(execute( |
Contributor
Author
There was a problem hiding this comment.
I moved to using the HLRC here because I did not want the ClusterRequestConverter used in this class.
Member
There was a problem hiding this comment.
I think it should be enough to just call the API without any assertion. We already should already throw an exception if the response isn't a 200.
Contributor
Author
There was a problem hiding this comment.
heh, so then we should remove the bool on the AcknowledgedResponse :)
nik9000
approved these changes
Sep 4, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 5, 2018
* master: Fix deprecated setting specializations (elastic#33412) HLRC: split cluster request converters (elastic#33400) HLRC: Add ML get influencers API (elastic#33389) Add conditional token filter to elasticsearch (elastic#31958) Build: Merge xpack checkstyle config into core (elastic#33399) Disable IndexRecoveryIT.testRerouteRecovery. INGEST: Implement Drop Processor (elastic#32278) [ML] Add field stats to log structure finder (elastic#33351) Add interval response parameter to AutoDateInterval histogram (elastic#33254) MINOR+CORE: Remove Dead Methods ClusterService (elastic#33346)
hub-cap
added a commit
that referenced
this pull request
Sep 5, 2018
In an effort to encapsulate the different clients, the request converters are being shuffled around. This splits the ClusterClient request converters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to encapsulate the different clients, the request
converters are being shuffled around. This splits the ClusterClient
request converters.