Test that transient settings beat persistent ones #33818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transient settings override persistent settings, but in fact all of the tests that run as part of `:server:test` and `:server:integTest` will pass if the precedence is changed to be the other way round. This change adds a test that verifies the precedence is as documented.
DaveCTurner
added
>non-issue
:Core/Infra/Settings
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
reviewed
Sep 18, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
Thanks for adding this test, it's really good to have tests for fundamental assumptions such as this. 🙈
I left a request.
| .persistentSettings(Settings.builder().put("key", "persistent-value").build()) | ||
| .transientSettings(Settings.builder().put("key", "transient-value").build()).build(); | ||
|
|
||
| assertThat(metaData.settings().get("key"), equalTo("transient-value")); |
Member
There was a problem hiding this comment.
I did not check but I think it should be possible to test this with a setting object instead doing a raw get on the settings instance; that is Settings#get(String) versus Setting#get(settings). Would you please write the test that way? It is more realistic.
Contributor
Author
There was a problem hiding this comment.
Yes, this was possible. I pushed 1ec65d0.
…18-test-transient-settings-override-persistent-ones
DaveCTurner
deleted the
2018-09-18-test-transient-settings-override-persistent-ones
branch
DaveCTurner
added a commit
that referenced
this pull request
Sep 20, 2018
Transient settings override persistent settings, but in fact all of the tests that run as part of `:server:test` and `:server:integTest` will pass if the precedence is changed to be the other way round. This change adds a test that verifies the precedence is as documented.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Transient settings override persistent settings, but in fact all of the tests that run as part of `:server:test` and `:server:integTest` will pass if the precedence is changed to be the other way round. This change adds a test that verifies the precedence is as documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transient settings override persistent settings, but in fact all of the tests
that run as part of
:server:testand:server:integTestwill pass if theprecedence is changed to be the other way round. This change adds a test that
verifies the precedence is as documented.