[Painless] Add a Map for java names to classes for use in the custom classloader #34424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that wasn't including the class used for a static import where only the static import is whitelisted.
jdconrad
added
>bug
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra |
rjernst
reviewed
Oct 12, 2018
| Class<?> existingClass = javaClassNamesToClasses.get(clazz.getName()); | ||
|
|
||
| if (existingClass == null) { | ||
| javaClassNamesToClasses.put(clazz.getName(), existingClass); |
There was a problem hiding this comment.
Why are you putting existingClass which is null, shouldn't it be clazz?
|
This whole thing needs docs. It's actually on my list to do for both this class and the PainlessLookup class. If it's all right I would like to do that as one PR together instead of just adding a couple bits here. |
|
Can you at least add a single line // comment indicating one is a superset? And also a test would be good |
|
You could also add a check in the lookup constructor ensuring the superset precondition |
|
It's not a superset. Will add a comment. |
|
Comments added. |
|
Point noted: I was thinking of the names, the values are a superset. |
|
@rjernst Thanks for the review! |
jdconrad
added a commit
that referenced
this pull request
Oct 12, 2018
…classloader (#34424) This fixes a bug that wasn't including the class used for a static import where only the static import is whitelisted.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 15, 2018
* elastic/master: Mute PartitionedRoutingIT#testShrinking on Windows Mute testToQuery test [TEST] Make sure there are shards started so that `ESIntegTestCase#assertSameDocIdsOnShards()` does not fail with shard not found. Change shard changes api's threadpool from get to search (elastic#34421) Update TESTING.asciidoc title (elastic#34401) Tests: Fix DateFormatter equals tests with locale (elastic#34435) Docs: Remove unnecessary qualifier from wildcard import note (elastic#34419) CCR/TEST: AwaitsFix testFailOverOnFollower [Painless] Add a Map for java names to classes for use in the custom classloader (elastic#34424) TEST: Fix indentation in FullClusterRestartIT (elastic#34420) [WIP] Ingest Attachement: Upgrade tika to v1.19.1 (elastic#33896) NETWORKING: Upgrade Netty to 4.1.30 (elastic#34417) Allow an AuthenticationResult to return metadata (elastic#34382) [ML] Add an ingest pipeline definition to structure finder (elastic#34350) Handle pre-6.x time fields (elastic#34373) ListenableFuture should preserve ThreadContext (elastic#34394)
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
…classloader (#34424) This fixes a bug that wasn't including the class used for a static import where only the static import is whitelisted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that wasn't including the class used for a static import where only the static import is whitelisted. This affects extensions that use classes that are not part of the core.