Skip to content

MINOR: Remove Dead Code in ExpressionTermSetQuery #34442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
original-brownbear merged 1 commit into from
Oct 15, 2018
Merged

MINOR: Remove Dead Code in ExpressionTermSetQuery #34442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...-expression/src/main/java/org/elasticsearch/script/expression/ExpressionScriptEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,7 @@ private TermsSetQueryScript.LeafFactory newTermsSetQueryScript(Expression expr,
throw convertToScriptException("link error", expr.sourceText, variable, e);
}
}
ReplaceableConstDoubleValueSource specialValue = null;
return new ExpressionTermSetQueryScript(expr, bindings, specialValue);
return new ExpressionTermSetQueryScript(expr, bindings);
}

/**
Expand Down
4 changes: 1 addition & 3 deletions ...ssion/src/main/java/org/elasticsearch/script/expression/ExpressionTermSetQueryScript.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,11 @@ class ExpressionTermSetQueryScript implements TermsSetQueryScript.LeafFactory {
final Expression exprScript;
final SimpleBindings bindings;
final DoubleValuesSource source;
final ReplaceableConstDoubleValueSource specialValue; // _value

ExpressionTermSetQueryScript(Expression e, SimpleBindings b, ReplaceableConstDoubleValueSource v) {
ExpressionTermSetQueryScript(Expression e, SimpleBindings b) {
exprScript = e;
bindings = b;
source = exprScript.getDoubleValuesSource(bindings);
specialValue = v;
}

@Override
Expand Down