remove ILM API remove_policy #34819
Closed
remove ILM API remove_policy #34819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since elastic#34304, `index.lifecycle.name` is no longer an internal index setting. This was done to simplify the API and remove the dedicated API for setting a policy on an index after it was created. The idea is that this is best done as an index setting update. The same could be said about the remove_policy API. This commit removes the dedicated API command to remove a policy from an index. Update Settings API should be used instead to set `index.lifecycle.name` to null or the empty string.
talevy
added
WIP
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
|
Note tere is already an issue for this here: #34310 |
Contributor
Author
|
thanks @colings86, forgot! |
Contributor
|
I don't think we should remove this API unless we have implemented #34310 so the other ILM state is removed from the index at the same time. Without this we will have no way of cleaning up the ILM state for an index completely so I think this API should remain for now. We should tackle #34310 at a later date since it is non-trivial because it requires the index settings consumers to be changed to be aware of the index they are acting on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #34304,
index.lifecycle.nameis no longer aninternal index setting. This was done to simplify the API
and remove the dedicated API for setting a policy on an index
after it was created. The idea is that this is best done as an
index setting update. The same could be said about the remove_policy
API.
This commit removes the dedicated API command to remove a policy
from an index. Update Settings API should be used instead to
set
index.lifecycle.nameto null or the empty string.TODO: Discussion
One point of discussion is how to handle the scenarios that remove_policy
handled safely beforehand.