HLRC: DRY up remaining CRUD docs #34925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>docs
|
Pinging @elastic/es-core-infra |
cbuescher
reviewed
Oct 29, 2018
| // end::update-by-query-response | ||
| } | ||
| { | ||
| UpdateByQueryRequest request = new UpdateByQueryRequest(); | ||
| request.indices("source1"); | ||
|
|
||
| ActionListener<BulkByScrollResponse> listener; |
There was a problem hiding this comment.
Kind of unfortunate that we have to do things like this to avoid long lines, but so be it.
|
Thanks for reviewing @cbuescher! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further applies the pattern set in #34125 to reduce copy-and-paste
in the multi-document CRUD portion of the High Level REST Client docs.
It also adds line wraps to snippets that are too wide to fit into the box
when rendered in the docs, following up on the work started in #34163.