-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingest: raise visibility of ingest plugin documentation #35048
ingest: raise visibility of ingest plugin documentation #35048
Conversation
Pinging @elastic/es-core-infra |
requesting @eskibars review based on #33188 (comment) |
This seems like the wrong place to mention the set user processor, as it is not installed as a normal plugin; it comes with the default distribution. The others must be installed as normal elasticsearch plugins. |
good point ! Let me try something different... adding WIP label. |
Latest attempt to raise visibility of the Set Security User Processor is to move the documentation for it to primary documentation. This works because it is now part of the default distribution and will just work if security is setup. I included an IMPORTANT section to help ensure that it is obvious that an authenticated user is required, which by inference means this only works with the default distribution. @lcawl @eskibars - could I get your opinion on adding this documentation to the main documentation that is dependent on security enabled + default distribution ? |
x-pack/docs/en/security/authorization/set-security-user.asciidoc
Outdated
Show resolved
Hide resolved
x-pack/docs/en/security/authorization/set-security-user.asciidoc
Outdated
Show resolved
Hide resolved
Co-Authored-By: jakelandis <jake.landis@elastic.co>
Co-Authored-By: jakelandis <jake.landis@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving this content makes sense to me. I submitted two minor suggestions, but think it would be good for @debadair to weigh in on the Elasticsearch table of contents.
@jakelandis Agree that moving the Set security user processor into the list of ingest processors makes sense. I'm less sure about adding the "Plugin Processors" topic after the Processors topic. I would be inclined to add that information to the top level Processors topic. I think the point you're trying to make is that there are the built-in processors described under Processes and additional ingest processors that can be installed as ES plugins? If so, I'd be inclined to add the folliowing section to the bottom of the Processors page:
That way, people aren't confused about the difference between "Processors" and "Plugin Processors" and (hopefully) will avoid an extra click. |
@jakelandis I ran the documentation builds and the changes look good to me. |
LGTM, thanks! |
LGTM! |
* move the set security user processor to the main documentation * link to plugin processors part of #33188
* move the set security user processor to the main documentation * link to plugin processors part of #33188
part of #33188
Updated processor page
Updated x-pack/stack doc
EDIT: updated description to match latest PR
EDIT2: updated description to match latest PR