Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Cleans up monitoring configuration steps #35111

Merged
merged 13 commits into from
Nov 8, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 31, 2018

This PR is related to elastic/stack-docs#138 and elastic/kibana#24881

It adds information that previously existed in https://www.elastic.co/guide/en/elastic-stack-overview/master/monitoring-production.html and removes information that is more appropriate for the Kibana documentation.

It also cleans up some of the "X-Pack" terminology.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@lcawl lcawl force-pushed the lcawley-monitor-es branch from 5b6fb05 to 851b1ae Compare November 1, 2018 17:22
@lcawl lcawl added v7.0.0 v6.5.0 v6.6.0 >docs General docs changes and removed WIP labels Nov 1, 2018
@lcawl lcawl requested a review from ycombinator November 1, 2018 17:28
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

--
{stack-ov}/built-in-roles.html[`remote_monitoring_agent` built-in role].
Alternatively, use the
{stack-ov}/built-in-users.html[`remote_monitoring_user` built-in user].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome change!

@lcawl
Copy link
Contributor Author

lcawl commented Nov 7, 2018

@ycombinator Should I add a comment about the CCR metricset (related to elastic/beats#8915)?

@ycombinator
Copy link
Contributor

@lcawl Thanks for checking but I think not, for now anyway. This is something we should handle in the product itself (per the discussion in elastic/beats#8915).

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM!

@lcawl
Copy link
Contributor Author

lcawl commented Nov 8, 2018

Verified success of local gradle build.

@lcawl lcawl merged commit c88b2d7 into elastic:master Nov 8, 2018
@lcawl lcawl deleted the lcawley-monitor-es branch November 8, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants