Remove version.qualified from MainResponse #35412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fully qualified version will be returned as `version.number`
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
|
@elasticmachine test this please |
|
@elasticmachine restest this please |
nik9000
reviewed
Nov 16, 2018
| @@ -150,15 +150,15 @@ public void testLookupRemoteVersion() throws Exception { | |||
| assertTrue(called.get()); | |||
| called.set(false); | |||
| sourceWithMockedRemoteCall(false, ContentType.APPLICATION_JSON, "main/5_0_0_alpha_3.json").lookupRemoteVersion(v -> { | |||
| // V_5_0_0_alpha3 | |||
| assertEquals(Version.fromId(5000003), v); | |||
| // V_5_0_0 since we no longer consider qualifier in Version | |||
|
@elasticmachine test this please |
|
@elasticmachine test this please |
|
@nik9000 can you take another look ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concluding the discussions after merging #35334.
version.qualifiedis removed from the main response andthe fully qualified version will be returned as
version.number.