Tests- added helper methods to ESRestTestCase for checking warnings #36443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
>test
|
Pinging @elastic/es-core-features |
nik9000
reviewed
Dec 10, 2018
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/test/java/org/elasticsearch/client/SearchIT.java
Outdated
Show resolved
Hide resolved
markharwood
force-pushed
the
fix/36251VersionedWarningsHandler
branch
2 times, most recently
from
c00410a to
ba91f58
Compare
nik9000
approved these changes
Dec 11, 2018
| @@ -177,6 +181,69 @@ public void initClient() throws IOException { | |||
| assert hasXPack != null; | |||
| assert nodeVersions != null; | |||
| } | |||
|
|
|||
| // Helper class to check warnings in REST responses with sensitivity to versions | |||
There was a problem hiding this comment.
Could you use Javadoc here? I'm just so used to it in this context that anything else is like a cognitive speed bump.
|
Thanks for doing this @markharwood! |
javanna
approved these changes
Dec 11, 2018
|
|
||
| } | ||
|
|
||
| public static RequestOptions expectVersionSpecificWarnings(Consumer<VersionSensitiveWarningsHandler> expectationsSetter) { |
There was a problem hiding this comment.
nit: maybe this should be protected?
There was a problem hiding this comment.
It was protected originally but Nik requested it be made public static to allow use from elsewhere.
… and current-version-only clusters. This is supported by a new VersionSpecificWarningsHandler class with associated unit test. Closes elastic#36251
markharwood
force-pushed
the
fix/36251VersionedWarningsHandler
branch
from
11f9385 to
033bfca
Compare
jasontedor
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Dec 11, 2018
* elastic/master: (36 commits) Add check for minimum required Docker version (elastic#36497) Minor search controller changes (elastic#36479) Add default methods to DocValueFormat (elastic#36480) Fix the mixed cluster REST test explain/11_basic_with_types. Modify `BigArrays` to take name of circuit breaker (elastic#36461) Move LoggedExec to minimumRuntime source set (elastic#36453) added 6.5.4 version Add test logging for elastic#35644 Tests- added helper methods to ESRestTestCase for checking warnings (elastic#36443) SQL: move requests' parameters to requests JSON body (elastic#36149) [Zen2] Respect the no_master_block setting (elastic#36478) Require soft-deletes when access changes snapshot (elastic#36446) Switch more tests to zen2 (elastic#36367) [Painless] Add extensive tests for def to primitive casts (elastic#36455) Add setting to bypass Rollover action (elastic#36235) Try running CI against Zulu (elastic#36391) [DOCS] Reworked the shard allocation filtering info. (elastic#36456) Log [initial_master_nodes] on formation failure (elastic#36466) converting ForbiddenPatternsTask to .java (elastic#36194) fixed typo ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper method for checking mixed and current-version-only clusters in Java REST tests that use LLRC or HLRC apis.
Closes #36251