Deprecate allow mmapfs #37095
Merged
Deprecate allow mmapfs #37095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we deprecate the setting `node.store.allow_mmapfs` and add a new setting `node.store.allow_mmap`. Previously this setting has controlled whether `mmapfs` could be used as a store type. With the introduction of `hybridfs` which also relies on memory-mapping the old setting name is no longer appropriate as it also applies to `hybridfs`and thus we rename it in order to convey that it is actually used to allow memory-mapping but not a specific store type. Relates elastic#37067 Relates elastic#37070
danielmitterdorfer
added
>deprecation
:Distributed Indexing/Engine
Collaborator
|
Pinging @elastic/es-distributed |
jpountz
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backport of #37070 on master, in which we rename
node.store.allow_mmapfstonode.store.allow_mmap. In this PR we reintroducenode.store.allow_mmapfsas a deprecated property.