Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types removal - add constants for include_type_names #37304

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Types removal - add constants for include_type_names #37304

merged 1 commit into from
Jan 10, 2019

Conversation

markharwood
Copy link
Contributor

Added constants for include_type_name parameter name and its default setting

@markharwood markharwood added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v6.7.0 labels Jan 10, 2019
@markharwood markharwood requested a review from cbuescher January 10, 2019 13:35
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

cbuescher
cbuescher approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@markharwood markharwood mentioned this pull request Jan 10, 2019
Merged
@markharwood markharwood merged commit 9ec27fd into elastic:6.x Jan 10, 2019
@jtibshirani
Copy link
Contributor

Thanks @markharwood !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees
No one assigned
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markharwood @elasticmachine @jtibshirani @cbuescher